Skip to content

fix(clippy): resolve upstream Clippy warnings breaking CI on main#1091

Open
Hypn0sis wants to merge 9 commits intoRightNow-AI:mainfrom
Hypn0sis:pr/fix-clippy-warnings
Open

fix(clippy): resolve upstream Clippy warnings breaking CI on main#1091
Hypn0sis wants to merge 9 commits intoRightNow-AI:mainfrom
Hypn0sis:pr/fix-clippy-warnings

Conversation

@Hypn0sis
Copy link
Copy Markdown
Contributor

@Hypn0sis Hypn0sis commented Apr 20, 2026

Summary

Resolves 9 Clippy warnings currently breaking the Clippy CI job on `main` (confirmed failing as of v0.6.0).

All fixes are in upstream code — no new features, no behaviour changes.

Warnings fixed

File Lint Fix
`openfang-runtime/src/drivers/gemini.rs` `collapsible_match` collapse nested `if let` into match guard
`openfang-runtime/src/drivers/openai.rs` (×2) `collapsible_match` same
`openfang-runtime/src/session_repair.rs` (×2) `unnecessary_sort_by` `sort_by(…)` → `sort_by_key(|b| Reverse(b.0))`
`openfang-migrate/src/openclaw.rs` `collapsible_match` collapse nested `if let` into match guard
`openfang-channels/src/irc.rs` `collapsible_match` same
`openfang-kernel/src/kernel.rs` `collapsible_match` + `unnecessary_sort_by` same patterns
`openfang-api/src/routes.rs` redundant `into_iter()` remove `.into_iter()` on reference
`openfang-cli/src/tui/screens/` (13 files) `collapsible_match` collapse nested match arms

Test plan

  • `cargo clippy --workspace -- -D warnings` passes with zero errors
  • `cargo test --workspace` all green
  • No behaviour changes — purely mechanical lint fixes

Hypn0sis added 9 commits April 20, 2026 10:33
@Hypn0sis
fix(clippy): resolve 5 upstream warnings introduced in v0.5.10
a78563e 
- gemini.rs: collapse nested if into match guard (collapsible_match)
- openai.rs (x2): same collapsible_match pattern in two message loops
- session_repair.rs (x2): sort_by -> sort_by_key with Reverse (unnecessary_sort_by)
@Hypn0sis
style: apply rustfmt to match guard format in openai.rs
feeee23
@Hypn0sis
fix(clippy): collapse if into match guard in openclaw.rs
32adaf3
@Hypn0sis
fix(clippy): collapse if into match guard in irc.rs
b5db0e5
@Hypn0sis
fix(clippy): collapsible_match and sort_by_key in kernel.rs
08a1ab5
@Hypn0sis
fix(clippy): remove redundant into_iter() in routes.rs
5f07b30
@Hypn0sis
fix(clippy): collapse if into match guards in all TUI screen files
db4c600
@Hypn0sis
fix(clippy): collapsible_match in agents, comms, audit, extensions sc…
3a8c144 
…reens
@Hypn0sis
fix(clippy): collapse Enter guard in comms.rs send modal
a8ada8f
@Hypn0sis
Copy link
Copy Markdown
Contributor Author

Hypn0sis commented Apr 20, 2026

CI results

  • ✅ Clippy — passes, all 9 warnings resolved
  • ✅ Tests (ubuntu / macos / windows) — all green
  • ✅ Check (ubuntu / macos / windows) — all green
  • ❌ Format — pre-existing issue on `main` itself (routes.rs, kernel.rs, cron_delivery.rs, config_injection.rs and others); same failure visible on the latest `main` CI run 24637821654 with no PR involved — not introduced by this PR
  • ❌ Security Audit — pre-existing `rand 0.9.2` (RUSTSEC-2026-0097) + `gimli 0.33.1` yanked, same as on `main`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hypn0sis